UI Expansion: Buying Game compat#68
Open
danaYatsuta wants to merge 1 commit intoNullCascade:masterfrom
Open
Conversation
Collaborator
|
Thanks for your contribution. I think this case should be handled on the Buying Game side, so I've sent VitruvianGuar a message and a patch. Will leave this open until that hopefully goes live. |
Author
|
Thank you! I also thought ideally it would be on Buying Game's side, but I didn't know (and still kinda don't lol) how that could be done. |
Collaborator
|
Here's the patch for reference- basically just check if the ratio exists, and hide it the same way as the gold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Buying Game is installed, only show value to weight ratio if player has mercantile skill high enough to see value.